[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 27 06:57:09 PST 2019
yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: lib/Sema/SemaDeclAttr.cpp:4620
const TargetInfo &TI = Context.getTargetInfo();
- TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC);
+ auto *Aux = Context.getAuxTargetInfo();
+ if (LangOpts.CUDA) {
----------------
rjmccall wrote:
> Please sink these declarations into the CUDA-specific block. Also, please add some comments to explain why different logic is needed for CUDA.
will do. thanks.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57716/new/
https://reviews.llvm.org/D57716
More information about the cfe-commits
mailing list