[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

A couple tweaks, but otherwise LGTM.



================
Comment at: clang/include/clang/AST/OperationKinds.def:203
 
+/// CK_FixedPointToIntegral - Fixed point to an integral.
+///    (int) 2.0k
----------------
This is super-picky, but please either just say "integral" (without an article) or spell out "an integral type".


================
Comment at: clang/include/clang/Basic/FixedPoint.h:157
+  /// to be fully stored in the provided width and sign, the overflow parameter
+  /// is set to true.
+  llvm::APSInt convertToInt(unsigned DstWidth, bool DstSign,
----------------
Please specify what happens to the overflow flag if there's a fractional component.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56900/new/

https://reviews.llvm.org/D56900