[PATCH] D58600: [clangd] Emit source to Diagnostic.

[Jan Korous via Phabricator via cfe-commits]

jkorous added inline comments.


================
Comment at: clangd/Diagnostics.cpp:381
     LastDiag = Diag();
+    LastDiag->ID = Info.getID();
     FillDiagBase(*LastDiag);
----------------
Nit - is this really intended to be part of this patch?


================
Comment at: clangd/Diagnostics.h:72
+  // Diagnostic enum ID.
+  unsigned ID;
+  // The source of this diagnostic, e.g. 'clang', 'clang-tidy'.
----------------
Nit - is this really intended to be part of this patch?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58600/new/

https://reviews.llvm.org/D58600