[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:28
+// FIXME: Should we emit coverage info for deleting dtors? They do contain
+// conditional branches. LLVM IR PGO will insrument them just fine, though.
+
----------------
vsk wrote:
> Probably not. IIUC the branches aren't visible at the source-level?
You're right, they aren't, so I'll remove this.


================
Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:52
+
+// LINUX-NOT: @__profn_{{.*}}D[01]Ev =
+// LINUX: @__profn__ZN10DerivedABCD2Ev =
----------------
vsk wrote:
> Do you need {{[01]}}?
Yes, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58691/new/

https://reviews.llvm.org/D58691