[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 26 01:59:26 PST 2019


martong added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:1344
+
+  EXPECT_EQ(FromChooseExpr->isConditionTrue(), ToChooseExpr->isConditionTrue());
+}
----------------
To  compensate the  skipping of the template test, perhaps we should have another expectation for the condition dependency of the expression:
```
EXPECT_EQ(FromChooseExpr->isConditionDependent(), ToChooseExpr->isConditionDependent());
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58663/new/

https://reviews.llvm.org/D58663





More information about the cfe-commits mailing list