[clang-tools-extra] r354780 - [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

[Clement Courbet via cfe-commits]

Author: courbet
Date: Mon Feb 25 05:09:02 2019
New Revision: 354780

URL: http://llvm.org/viewvc/llvm-project?rev=354780&view=rev
Log:
[clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

Summary: Tis represents ~20% of false positives. See PR27723.

Reviewers: xazax.hun, alexfh

Subscribers: rnkovacs, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D58604

Modified:
    clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp
    clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp

Modified: clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp?rev=354780&r1=354779&r2=354780&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp Mon Feb 25 05:09:02 2019
@@ -27,10 +27,15 @@ void StringIntegerAssignmentCheck::regis
           callee(cxxMethodDecl(ofClass(classTemplateSpecializationDecl(
               hasName("::std::basic_string"),
               hasTemplateArgument(0, refersToType(qualType().bind("type"))))))),
-          hasArgument(1,
-                      ignoringImpCasts(expr(hasType(isInteger()),
-                                            unless(hasType(isAnyCharacter())))
-                                           .bind("expr"))),
+          hasArgument(
+              1,
+              ignoringImpCasts(
+                  expr(hasType(isInteger()), unless(hasType(isAnyCharacter())),
+                       // Ignore calls to tolower/toupper (see PR27723).
+                       unless(callExpr(callee(functionDecl(
+                           hasAnyName("tolower", "std::tolower", "toupper",
+                                      "std::toupper"))))))
+                      .bind("expr"))),
           unless(isInTemplateInstantiation())),
       this);
 }

Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp?rev=354780&r1=354779&r2=354780&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/bugprone-string-integer-assignment.cpp Mon Feb 25 05:09:02 2019
@@ -11,8 +11,14 @@ struct basic_string {
 
 typedef basic_string<char> string;
 typedef basic_string<wchar_t> wstring;
+
+int tolower(int i);
+int toupper(int i);
 }
 
+int tolower(int i);
+int toupper(int i);
+
 typedef int MyArcaneChar;
 
 int main() {
@@ -50,4 +56,7 @@ int main() {
 // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: an integer is interpreted as a chara
 // CHECK-FIXES: {{^}}  as = 6;{{$}}
 
+  s += toupper(x);
+  s += tolower(x);
+  s += std::tolower(x);
 }