[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

[Kamil Rytarowski via Phabricator via cfe-commits]

krytarowski added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430
+    // system install from src
+    getDriver().SysRoot + "/usr/include/c++",
+  };
----------------
mgorny wrote:
> krytarowski wrote:
> > mgorny wrote:
> > > krytarowski wrote:
> > > > I propose to go for:
> > > > 
> > > > `getDriver().SysRoot + "/usr/include/c++/v1",` with a fallback for `getDriver().SysRoot + "/usr/include/c++",`
> > > > 
> > > > This innocent customization of paths triggers a lot of headache.
> > > > 
> > > > We should switch system location to `/usr/include/c++/v1` for next version of LLVM (9.0 as 8.0 is branched and will be released soon).
> > > > 
> > > > This way we will keep compat with legacy paths and new clang.
> > > This is already handled by the relative path (when `getDriver().Dir` is `/usr/bin`).
> > We still can build newer Clang in pkgsrc on newer base with headers moved to `/usr/include/v1/c++` and it will break.
> I don't understand. Why would it break? (besides the typo in the path)
clang will be installed into `/usr/pkg/bin/clang` and we want to reach the default headers in `/usr/include/c++/v1` (in a setup without installing libc++ in pkgsrc)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58592/new/

https://reviews.llvm.org/D58592