[PATCH] D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

I like this.  Can you start a discussion on cfe-dev (if you haven't already)?  This is user-visible so I want to be sure other vendors are happy with this; if not, we can hide it behind a CMake flag.



================
Comment at: lib/Basic/Version.cpp:117
+#ifndef NDEBUG
+  OS << " (assertions enabled)";
+#endif
----------------
Can we just make this `" (+asserts)"` or `" (-NDEBUG)"`?  If we wanted to generalize this, I'd expect to want a list of compiler features similar to CPU features.



Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58559/new/

https://reviews.llvm.org/D58559