[PATCH] D58518: [HIP] change kernel stub name

Fri Feb 22 14:20:48 PST 2019

tra requested changes to this revision.
tra added a subscriber: echristo.
tra added inline comments.
This revision now requires changes to proceed.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:1059
+        FD->hasAttr<CUDAGlobalAttr>())
+      MangledName = MangledName + ".stub";
+
----------------
Changing mangled name exposes this change to a wider scope of potential issues. Is the mangled name still valid after this change? I.e. will external demanglers have problem with it? Is `.` a valid symbol in mangled names on all platforms we support?

I think changing the name here is way too late and we should figure out how to change the stub name when we generate it.

@echristo Eric, what do you think?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58518/new/

https://reviews.llvm.org/D58518