[PATCH] D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: lib/Sema/SemaOpenMP.cpp:13195
-      } else {
-        MVLI.UDMapperList.push_back(nullptr);
       }
----------------
Is this correct for `from` clause?


================
Comment at: lib/Sema/SemaOpenMP.cpp:13237
-      } else {
-        MVLI.UDMapperList.push_back(nullptr);
       }
----------------
Same here: what about `from`?


================
Comment at: lib/Sema/TreeTransform.h:8821
+    TreeTransform<Derived> &TT, OMPMappableExprListClause<T> *C,
+    llvm::SmallVector<Expr *, 16> &Vars, CXXScopeSpec &MapperIdScopeSpec,
+    DeclarationNameInfo &MapperIdInfo,
----------------
`llvm::SmallVector<Expr *, 16> &` -> `llvm::SmallVectorImpl<Expr *> &`


================
Comment at: lib/Sema/TreeTransform.h:8823
+    DeclarationNameInfo &MapperIdInfo,
+    llvm::SmallVector<Expr *, 16> &UnresolvedMappers) {
+  // Transform expressions in the list.
----------------
llvm::SmallVector<Expr *, 16> & -> llvm::SmallVectorImpl<Expr *> &


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58523/new/

https://reviews.llvm.org/D58523