[PATCH] D58548: IR: Support parsing numeric block ids, and emit them in textual output.

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 22 11:43:49 PST 2019


dexonsmith added a comment.

In D58548#1407331 <https://reviews.llvm.org/D58548#1407331>, @greened wrote:

> +1.  Is there any reason not to use "%4" in the definition?
>
>   define i32 @f(i32, i32) {
>     %3 = add i32 %0, %1
>     br label %4
>  
>   %4:
>     ret i32 %3
>   }
>
>
> Maybe it creates an ambiguity in the grammar or something.


A `%` isn't used for labels that do have names, so David's approach seems consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58548/new/

https://reviews.llvm.org/D58548





More information about the cfe-commits mailing list