[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

Fri Feb 22 06:27:51 PST 2019

klimek added a comment.

In D58345#1406892 <https://reviews.llvm.org/D58345#1406892>, @sammccall wrote:

> Sorry to be a pain here, but I'm not sure introducing Javascript is a good idea unless there's a strong reason for it.
>  All LLVM developers have python installed, many are comfortable with the language - it seems less likely to be a maintenance hazard. I can recommend BeautifulSoup for the HTML parsing stuff.
>  (For the record, I kind of hate python, but I'm more comfortable reviewing and maintaining it than JS).
>  Mitigating points: we have some in the VSCode plugin by necessity, and this isn't a build-time dependency.
>
> Happy to get another opinion here.
>
> > Added the tool in this patch, but I think a separate repository under GitHub's clangd org might be a more suitable place.
>
> I'm somewhat sympathetic to this idea, but I don't think we can do it as things stand. @klimek can confirm.

I unfortunately agree with Sam on this.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58345/new/

https://reviews.llvm.org/D58345