[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

Fri Feb 22 06:27:49 PST 2019

djtodoro marked an inline comment as done.
djtodoro added a comment.

@riccibruno Thanks for your comments!

> Oh and I think that you will also have to update the serialization code/de-serialization code in ASTReaderDecl.cpp / ASTWriterDecl.cpp. You might also have to update TreeTransform but I am less familiar with this.

I've added `ASTReaderDecl.cpp` / `ASTWriterDecl.cpp`, but looking at `TreeTransform ` I'm not sure if there is a place for adding something regarding this.

> I am wondering about the semantics of this bit. I don't think that you can know for sure within clang whether a variable has been modified. The best you can do is know for sure that some variable has been modified, but I don't think you can prove that it has not been modified.

> Consequently I am wondering if you should change the name of this flag to something like IsArgumentKnownToBeModified.

> Orthogonal to this you need to also add tests for templates.

I agree! You are right, good idea!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58035/new/

https://reviews.llvm.org/D58035