[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

Fri Feb 22 01:32:33 PST 2019

kadircet marked an inline comment as done.
kadircet added inline comments.

================
Comment at: clangd/Threading.cpp:125
+#elif defined(__APPLE__)
+  // https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/getpriority.2.html
+  setpriority(PRIO_DARWIN_THREAD, 0,
----------------
ilya-biryukov wrote:
> This points into `iPhoneOS` docs, might be confusing.
> Is there a link for the desktop version of the OS somewhere?
> Could also leave it out, I'm sure setpriority is easy to google.
It still says `This document is a Mac OS X manual page.` on top of the page, couldn't find any url that contains something like `MacOS` instead of `iPhoneOS`

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58492/new/

https://reviews.llvm.org/D58492