[PATCH] D57896: Variable names rule
Zachary Turner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 21 14:06:08 PST 2019
zturner added a comment.
In D57896#1406401 <https://reviews.llvm.org/D57896#1406401>, @probinson wrote:
> In D57896#1406353 <https://reviews.llvm.org/D57896#1406353>, @MyDeveloperDay wrote:
>
> > I can't argue with anything you say.. but I guess to reinforce your point introducing what is effectively a 3rd style would likely cause even more jarring...
>
>
> Zach isn't introducing a new style, the style already exists and is consistently used by what I think is our 3rd largest subproject. It happens not to be used at all by the two largest subprojects, but those subprojects already aren't consistent with themselves.
> I would not mind a more concerted effort to migrate to whatever style we pick, which was notably lacking last time around. Then the jarring inconsistencies would go away, and we could all get back to complaining about content and not style.
If I read the post correctly, it was actually agreeing with me (because it said "to reinforce your point...". Meaning that something such as `lowerCaseCamel` would be the third style being referred to, while my proposal keeps the number of styles to 2. But, maybe I read it wrong. If I read it right, then obviously I agree :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57896/new/
https://reviews.llvm.org/D57896
More information about the cfe-commits
mailing list