[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 21 13:12:58 PST 2019


riccibruno added a comment.

If this bit is relevant to function parameters, why is `getIsArgumentModified` in `VarDecl` and not in `ParamVarDecl` ? What you can do is move the relevant methods to `ParamVarDecl`, and stash the bit in `ParmVarDeclBitfields`.



================
Comment at: include/clang/AST/Decl.h:843
 
+  mutable bool IsArgumentModified = false;
+
----------------
Yeah, please don't waste a whole pointer just to store a bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58035/new/

https://reviews.llvm.org/D58035





More information about the cfe-commits mailing list