[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

[Paul Robinson via Phabricator via cfe-commits]

probinson added inline comments.


================
Comment at: include/clang/AST/Decl.h:1482
 
+  bool getIsArgumentModified() const {
+    return IsArgumentModified;
----------------
There should be a comment here.
The style in this class appears to omit the 'get' word from the name of the getter, so `isArgumentModified`  for the method name would look more consistent.


================
Comment at: lib/Sema/SemaExpr.cpp:11282
+static void EmitArgumentsValueModification(Expr *E) {
+  if (const DeclRefExpr *LHSDeclRef =
+          dyn_cast<DeclRefExpr>(E->IgnoreParenCasts()))
----------------
Does this fit on one line if you use `const auto *LHSDeclRef ...`? Given you have the dyn_cast on the RHS there's no real need to give the type name twice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58035/new/

https://reviews.llvm.org/D58035