r354596 - Revert "[CUDA]Delayed diagnostics for the asm instructions."
Alexey Bataev via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 21 08:40:22 PST 2019
Author: abataev
Date: Thu Feb 21 08:40:21 2019
New Revision: 354596
URL: http://llvm.org/viewvc/llvm-project?rev=354596&view=rev
Log:
Revert "[CUDA]Delayed diagnostics for the asm instructions."
This reverts commit r354593 to fix the problem with the crash on
windows.
Removed:
cfe/trunk/test/SemaCUDA/asm_delayed_diags.cu
Modified:
cfe/trunk/lib/Sema/Sema.cpp
cfe/trunk/lib/Sema/SemaExprCXX.cpp
cfe/trunk/lib/Sema/SemaStmt.cpp
cfe/trunk/lib/Sema/SemaStmtAsm.cpp
Modified: cfe/trunk/lib/Sema/Sema.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.cpp?rev=354596&r1=354595&r2=354596&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/Sema.cpp (original)
+++ cfe/trunk/lib/Sema/Sema.cpp Thu Feb 21 08:40:21 2019
@@ -1487,12 +1487,10 @@ void Sema::markKnownEmitted(
}
}
-Sema::DeviceDiagBuilder Sema::targetDiag(SourceLocation Loc, unsigned DiagID) {
+Sema::DeviceDiagBuilder Sema::targetDiag(SourceLocation Loc,
+ unsigned DiagID) {
if (LangOpts.OpenMP && LangOpts.OpenMPIsDevice)
return diagIfOpenMPDeviceCode(Loc, DiagID);
- if (getLangOpts().CUDA)
- return getLangOpts().CUDAIsDevice ? CUDADiagIfDeviceCode(Loc, DiagID)
- : CUDADiagIfHostCode(Loc, DiagID);
return DeviceDiagBuilder(DeviceDiagBuilder::K_Immediate, Loc, DiagID,
getCurFunctionDecl(), *this);
}
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExprCXX.cpp?rev=354596&r1=354595&r2=354596&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExprCXX.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExprCXX.cpp Thu Feb 21 08:40:21 2019
@@ -750,7 +750,7 @@ ExprResult Sema::BuildCXXThrow(SourceLoc
bool IsThrownVarInScope) {
// Don't report an error if 'throw' is used in system headers.
if (!getLangOpts().CXXExceptions &&
- !getSourceManager().isInSystemHeader(OpLoc) && !getLangOpts().CUDA) {
+ !getSourceManager().isInSystemHeader(OpLoc)) {
// Delay error emission for the OpenMP device code.
targetDiag(OpLoc, diag::err_exceptions_disabled) << "throw";
}
Modified: cfe/trunk/lib/Sema/SemaStmt.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaStmt.cpp?rev=354596&r1=354595&r2=354596&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaStmt.cpp (original)
+++ cfe/trunk/lib/Sema/SemaStmt.cpp Thu Feb 21 08:40:21 2019
@@ -3993,7 +3993,7 @@ StmtResult Sema::ActOnCXXTryBlock(Source
ArrayRef<Stmt *> Handlers) {
// Don't report an error if 'try' is used in system headers.
if (!getLangOpts().CXXExceptions &&
- !getSourceManager().isInSystemHeader(TryLoc) && !getLangOpts().CUDA) {
+ !getSourceManager().isInSystemHeader(TryLoc)) {
// Delay error emission for the OpenMP device code.
targetDiag(TryLoc, diag::err_exceptions_disabled) << "try";
}
Modified: cfe/trunk/lib/Sema/SemaStmtAsm.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaStmtAsm.cpp?rev=354596&r1=354595&r2=354596&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaStmtAsm.cpp (original)
+++ cfe/trunk/lib/Sema/SemaStmtAsm.cpp Thu Feb 21 08:40:21 2019
@@ -253,6 +253,15 @@ StmtResult Sema::ActOnGCCAsmStmt(SourceL
// The parser verifies that there is a string literal here.
assert(AsmString->isAscii());
+ // If we're compiling CUDA file and function attributes indicate that it's not
+ // for this compilation side, skip all the checks.
+ if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
+ GCCAsmStmt *NS = new (Context) GCCAsmStmt(
+ Context, AsmLoc, IsSimple, IsVolatile, NumOutputs, NumInputs, Names,
+ Constraints, Exprs.data(), AsmString, NumClobbers, Clobbers, RParenLoc);
+ return NS;
+ }
+
for (unsigned i = 0; i != NumOutputs; i++) {
StringLiteral *Literal = Constraints[i];
assert(Literal->isAscii());
Removed: cfe/trunk/test/SemaCUDA/asm_delayed_diags.cu
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCUDA/asm_delayed_diags.cu?rev=354595&view=auto
==============================================================================
--- cfe/trunk/test/SemaCUDA/asm_delayed_diags.cu (original)
+++ cfe/trunk/test/SemaCUDA/asm_delayed_diags.cu (removed)
@@ -1,118 +0,0 @@
-// RUN: %clang_cc1 -fsyntax-only -verify %s -DHOST -triple x86_64-unknown-linux-gnu
-// RUN: %clang_cc1 -fsyntax-only -verify %s -DHOST -DHOST_USED -triple x86_64-unknown-linux-gnu
-// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -verify %s -DDEVICE_NOT_USED -triple nvptx-unknown-cuda
-// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -verify %s -DDEVICE -triple nvptx-unknown-cuda
-// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -verify %s -DDEVICE -DDEVICE_USED -triple nvptx-unknown-cuda
-
-// REQUIRES: x86-registered-target
-// REQUIRES: nvptx-registered-target
-
-#if (defined(HOST) && !defined(HOST_USED)) || defined(DEVICE_NOT_USED)
-// expected-no-diagnostics
-#endif
-
-#include "Inputs/cuda.h"
-
-static __device__ __host__ void t1(int r) {
- __asm__("PR3908 %[lf] %[xx] %[li] %[r]"
- : [ r ] "+r"(r)
- : [ lf ] "mx"(0), [ li ] "mr"(0), [ xx ] "x"((double)(0)));
-}
-
-static __device__ __host__ unsigned t2(signed char input) {
- unsigned output;
- __asm__("xyz"
- : "=a"(output)
- : "0"(input));
- return output;
-}
-
-static __device__ __host__ double t3(double x) {
- register long double result;
- __asm __volatile("frndint"
- : "=t"(result)
- : "0"(x));
- return result;
-}
-
-static __device__ __host__ unsigned char t4(unsigned char a, unsigned char b) {
- unsigned int la = a;
- unsigned int lb = b;
- unsigned int bigres;
- unsigned char res;
- __asm__("0:\n1:\n"
- : [ bigres ] "=la"(bigres)
- : [ la ] "0"(la), [ lb ] "c"(lb)
- : "edx", "cc");
- res = bigres;
- return res;
-}
-
-static __device__ __host__ void t5(void) {
- __asm__ __volatile__(
- "finit"
- :
- :
- : "st", "st(1)", "st(2)", "st(3)",
- "st(4)", "st(5)", "st(6)", "st(7)",
- "fpsr", "fpcr");
-}
-
-typedef long long __m256i __attribute__((__vector_size__(32)));
-static __device__ __host__ void t6(__m256i *p) {
- __asm__ volatile("vmovaps %0, %%ymm0" ::"m"(*(__m256i *)p)
- : "ymm0");
-}
-
-static __device__ __host__ void t7(__m256i *p) {
- __asm__ volatile("vmovaps %0, %%ymm0" ::"m"(*(__m256i *)p)
- : "r0");
-}
-
-#ifdef DEVICE
-__device__ int m() {
- t1(0);
- t2(0);
- t3(0);
- t4(0, 0);
- t5();
- t6(0);
-#ifdef DEVICE_USED
- t7(0);
-#endif // DEVICE_USED
- return 0;
-}
-#endif // DEVICE
-
-#ifdef HOST
-__host__ int main() {
- t1(0);
- t2(0);
- t3(0);
- t4(0, 0);
- t5();
- t6(0);
-#ifdef HOST_USED
- t7(0);
-#endif // HOST_USED
- return 0;
-}
-#endif // HOST
-
-#if defined(HOST_USED)
-// expected-error at 69 {{unknown register name 'r0' in asm}}
-// expected-note at 96 {{called by 'main'}}
-#elif defined(DEVICE)
-// expected-error at 19 {{invalid input constraint 'mx' in asm}}
-// expected-error at 25 {{invalid output constraint '=a' in asm}}
-// expected-error at 33 {{invalid output constraint '=t' in asm}}
-// expected-error at 44 {{invalid output constraint '=la' in asm}}
-// expected-error at 56 {{unknown register name 'st' in asm}}
-// expected-error at 64 {{unknown register name 'ymm0' in asm}}
-// expected-note at 74 {{called by 'm'}}
-// expected-note at 75 {{called by 'm'}}
-// expected-note at 76 {{called by 'm'}}
-// expected-note at 77 {{called by 'm'}}
-// expected-note at 78 {{called by 'm'}}
-// expected-note at 79 {{called by 'm'}}
-#endif
More information about the cfe-commits
mailing list