[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 21 06:38:09 PST 2019


hokein accepted this revision.
hokein added inline comments.


================
Comment at: unittests/clangd/XRefsTests.cpp:462
       Foo a = $1^str;
-      Foo b = Foo($2^str);
+      Foo b = F$9^oo($2^str);
       Foo c = $3^f();
----------------
nit: keep the number in sort.


================
Comment at: unittests/clangd/XRefsTests.cpp:482
+  EXPECT_THAT(locateSymbolAt(AST, T.point("9")),
+              // First one is calss definition, second is the constructor.
+              ElementsAre(Sym("Foo"), Sym("Foo")));
----------------
s/calss/class


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58495/new/

https://reviews.llvm.org/D58495





More information about the cfe-commits mailing list