[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

+1 on removing the implicit references, sometimes it gives very confusing results.



================
Comment at: clangd/XRefs.cpp:113
 
 struct DeclInfo {
   const Decl *D;
----------------
This structure is not used anymore, remove it.


================
Comment at: clangd/XRefs.cpp:124
   // explicitly in the code.
   // True means the declaration is explicitly referenced at least once; false
   // otherwise.
----------------
The comment is stale.


================
Comment at: unittests/clangd/XRefsTests.cpp:465
       $4^g($5^f());
       g($6^str);
     }
----------------
Can we add one more testcase?

```
Foo ab^c;
```


================
Comment at: unittests/clangd/XRefsTests.cpp:469
   auto AST = TestTU::withCode(T.code()).build();
   // Ordered assertions are deliberate: we expect a predictable order.
+  EXPECT_THAT(locateSymbolAt(AST, T.point("1")), ElementsAre(Sym("str")));
----------------
The comment is stale.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58495/new/

https://reviews.llvm.org/D58495