[PATCH] D57896: Variable names rule

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 21 01:07:14 PST 2019


MyDeveloperDay added a comment.

In D57896#1402280 <https://reviews.llvm.org/D57896#1402280>, @zturner wrote:

> Since someone already accepted this, I suppose I should mark require changes to formalize my dissent


As it was Chris @lattner who accepted it, is your request for changes just based on the fact that it doesn't fit LLDB style?

I was trying to find where the LLDB coding style was documented but could only find this https://llvm.org/svn/llvm-project/lldb/branches/release_36/www/lldb-coding-conventions.html, seemingly this file has been move/removed around release 3.9.

But reading that link its seems unlikely to find a concencous between either naming conventions or formatting style between LLDB and the rest of LLVM, unless of course the solution would be to adopt LLDB style completely (for which I'd suspect there would be counter objections)

If that isn't a reality is blocking the rest of the LLVM community from relieving some of their eye strain an acceptable solution?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57896/new/

https://reviews.llvm.org/D57896





More information about the cfe-commits mailing list