[PATCH] D58478: [index-while-building] FileIndexRecord

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang/include/clang/Index/DeclOccurrence.h:1
+//===--- DeclOccurrence.h - An occurrence of a decl within a file ---------===//
+//
----------------
Missing C++ tag. See other headers as example.


================
Comment at: clang/include/clang/Index/DeclOccurrence.h:5
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
----------------
License should be updated.


================
Comment at: clang/include/clang/Index/DeclOccurrence.h:42
+
+#endif
----------------
Missing comment with header guard.


================
Comment at: clang/lib/Index/FileIndexRecord.cpp:45
+  for (auto &DclInfo : Decls) {
+    auto D = DclInfo.Dcl;
+    SourceManager &SM = D->getASTContext().getSourceManager();
----------------
Type is not obvious, so auto should not be used.


================
Comment at: clang/lib/Index/FileIndexRecord.h:1
+//===--- FileIndexRecord.h - Index data per file --------------------------===//
+//
----------------
Missing C++ tag. See other headers as example.


================
Comment at: clang/lib/Index/FileIndexRecord.h:5
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
----------------
License should be updated.


================
Comment at: clang/lib/Index/FileIndexRecord.h:58
+
+#endif
----------------
Missing comment with header guard.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58478/new/

https://reviews.llvm.org/D58478