[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 20 04:35:23 PST 2019


nemanjai added a comment.

In D49754#1402790 <https://reviews.llvm.org/D49754#1402790>, @vit9696 wrote:

> This is a series of patches, which I believe should merged altogether. Currently the following patches are relevant:


No, please don't merge them together. It is much more manageable for review when they're separate patches. I realize that this makes it a bit more difficult for the author to keep the dependency ordering straight, but I think preference needs to be given to the "reviewability" of the code.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49754/new/

https://reviews.llvm.org/D49754





More information about the cfe-commits mailing list