[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: lib/Sema/SemaStmtAsm.cpp:256-263
   // If we're compiling CUDA file and function attributes indicate that it's not
   // for this compilation side, skip all the checks.
   if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
     GCCAsmStmt *NS = new (Context) GCCAsmStmt(
         Context, AsmLoc, IsSimple, IsVolatile, NumOutputs, NumInputs, Names,
         Constraints, Exprs.data(), AsmString, NumClobbers, Clobbers, RParenLoc);
     return NS;
----------------
ABataev wrote:
> tra wrote:
> > Now that inline asm errors are delayed, do we still need this check?
> With this patch, it is going to be delayed only for OpenMP. After the commit, we could extend it for CUDA and remove this code. But not at the moment.
SGTM. 


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58243/new/

https://reviews.llvm.org/D58243