[PATCH] D58243: [OPENMP] Delay emission of the asm target-specific error messages.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 19 10:45:43 PST 2019


tra added inline comments.


================
Comment at: lib/Sema/SemaStmtAsm.cpp:256-263
   // If we're compiling CUDA file and function attributes indicate that it's not
   // for this compilation side, skip all the checks.
   if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
     GCCAsmStmt *NS = new (Context) GCCAsmStmt(
         Context, AsmLoc, IsSimple, IsVolatile, NumOutputs, NumInputs, Names,
         Constraints, Exprs.data(), AsmString, NumClobbers, Clobbers, RParenLoc);
     return NS;
----------------
Now that inline asm errors are delayed, do we still need this check?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58243/new/

https://reviews.llvm.org/D58243





More information about the cfe-commits mailing list