[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 19 09:30:01 PST 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM, but see the comment about avoiding code duplication



================
Comment at: lib/Index/IndexDecl.cpp:678
             IndexCtx.indexTypeSourceInfo(TTP->getDefaultArgumentInfo(), Parent);
+          if(IndexCtx.shouldIndexTemplateParameters())
+            IndexCtx.handleDecl(TTP);
----------------
Maybe do it once on top of `TP` to avoid code duplication?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58293/new/

https://reviews.llvm.org/D58293





More information about the cfe-commits mailing list