[PATCH] D57896: Variable names rule

[Zachary Turner via Phabricator via cfe-commits]

zturner added a comment.

In D57896#1402194 <https://reviews.llvm.org/D57896#1402194>, @lattner wrote:

> > Changed recommendation for acronyms from lower case to upper case, as suggested by several responses to the RFC.
>
> I haven't been following the discussion closely - why is this the preferred direction?  I don't think that things like "Basicblock *bb" or "MachineInstr *mi" will be confusing, and going towards a consistently leading lower case letter seems simple and preferable.
>
> -Chris


I don’t think we should use this review as evidence of consensus.  For example, I’m going to be against any change that doesn’t bring us closer to LLDB’s style of `lower_case` simply on the grounds that a move which brings us farther away from global consistency is strictly worse than one which brings us closer, despite ones personal aesthetic preferences.

And so far, I don’t really see that addressed here (or in the thread)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57896/new/

https://reviews.llvm.org/D57896