[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 19 02:04:03 PST 2019


baloghadamsoftware added a comment.

If I understand it correctly, this is more of an infrastructure improvement than check enhancement. It looks like a nice and clean code. Where do we expect to use this new behavior? In the current check or in the upcoming "modernize" check?



================
Comment at: clang-tidy/utils/ExceptionAnalyzer.h:128
+    /// throw, if it's unknown or if it won't throw.
+    enum State Behaviour : 4;
+
----------------
Why 4 bits, not just 2? Can we expect additional states?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57883/new/

https://reviews.llvm.org/D57883





More information about the cfe-commits mailing list