[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

[Tolga Mizrak via Phabricator via cfe-commits]

to-miz added a comment.

I understand that adding new options adds costs to the development of clang-format, but there was a feature request and there is interest for this option.
As for the cost to the development, there already exists PPDIS_AfterHash. All I did was make the changes introduced in that patch a bit more general and removed the hard coded assumption that there are no indents before a hash at a couple of places.
I would argue the cost of development of this new option is roughly the same as it is with the existence of PPDIS_AfterHash itself. PPDIS_BeforeHash seems like a natural extension of the changes introduced by PPDIS_AfterHash.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52150/new/

https://reviews.llvm.org/D52150