[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

Mon Feb 18 07:44:37 PST 2019

hokein marked an inline comment as done.
hokein added a comment.

In D58345#1401040 <https://reviews.llvm.org/D58345#1401040>, @ioeric wrote:

> Looks great! Thanks for doing this.
>
> Could you also check in the tool that is used to generate the mapping? We need a way to update the mapping when cppreference is updated.

The tool is not ready yet, I'm still polishing it, but the results are good, I think this patch should not be blocked by the tool.

================
Comment at: clangd/index/CanonicalIncludes.cpp:123

   static const std::vector<std::pair<const char *, const char *>>
       SystemHeaderMap = {
----------------
ioeric wrote:
> Can we remove the suffix header mapping now? Is it for the `std::chrono::` symbols? What are the reasons not to include them in this patch? 
Ideally, we could remove it once we get a perfect symbol mapping but I'd prefer to keep it (it serves as a fallback when we don't find symbols in the symbol mapping), so that we could add new symbol mapping increasingly without changing the current behavior.

Removing it should be done carefully without introducing regression, and is outside the scope of this patch.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58345/new/

https://reviews.llvm.org/D58345