[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 18 07:33:06 PST 2019


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

I think we need to  update the comment in the SymbolLocation::Column.



================
Comment at: clangd/tool/ClangdMain.cpp:9
 
+#include "/usr/local/google/home/sammccall/src/llvm/tools/clang/tools/extra/clangd/Protocol.h"
 #include "Features.inc"
----------------
the #include introduced by global code completion seems not get shortened.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58275/new/

https://reviews.llvm.org/D58275





More information about the cfe-commits mailing list