[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 16 10:09:47 PST 2019


JonasToth added inline comments.


================
Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:72
+
+    // Match the cases where we know that the result is a Duration and the first
+    // argument is a Time.  Just knowing the type of the first operand is not
----------------
Eugene.Zelenko wrote:
> JonasToth wrote:
> > please highlight the types with ''
> But do we do this in comments? Isn't it's Sphinx syntax?
We don't do it consistently, but its common to highlight direct usage of types in comments as well.
Sphinx uses backticks, but in comments any form of ticks are ok.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58137/new/

https://reviews.llvm.org/D58137





More information about the cfe-commits mailing list