[PATCH] D57910: [ASTImporter] Find previous friend function template

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 16 01:48:27 PST 2019


a_sidorin accepted this revision.
a_sidorin added a comment.

Hi Gabor,
This patch LGTM with a minor nit.



================
Comment at: unittests/AST/ASTImporterTest.cpp:5109
+  // Currently chains of FunctionTemplateDecls are not implemented
+  //EXPECT_EQ(Imported->getPreviousDecl(), Friend);
+  EXPECT_EQ(Imported, Friend);
----------------
This deserves a FIXME, I think.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57910/new/

https://reviews.llvm.org/D57910





More information about the cfe-commits mailing list