[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

After staring at this for an hour or two, i didn't manage to force myself to understand how our cluster analysis works here, but i totally agree that it's most likely broken; i guess, we should eventually move away from the idea that everything works through base regions, but for now this idea seems to be hardcoded in a lot of places.

That said, the patch does fix the test case that i provided, but it doesn't fix my original regression :( so i'll run the reduce again to see if i have more to say. And i'll also try harder to understand what's going on.



================
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1039
       B = B.remove(baseR);
-  }
+  } 
 
----------------
The patch introduces a whitespace error here :p


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58121/new/

https://reviews.llvm.org/D58121