[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.
Dan Albert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 15 17:00:11 PST 2019
danalbert created this revision.
danalbert added reviewers: peter.smith, kristof.beyls, srhines, pirama.
Herald added a subscriber: javed.absar.
Herald added a project: clang.
The ARM gas driver previously enabled NEON for ARMv7 and up, and a
handful of other extensions for ARMv8 and up (although only if the
architecture version was a part of the triple; the -march flag was
not honored). Neither of these are actually guaranteed, and the
behavior does not match the integrated assembler.
Note that I've elected to always pass an explicit -march flag to gas
if the user has not specified one. I'm not certain if Clang's default
ARM version matches GNU's, so being explicit allows us to keep the
same behavior if that isn't the case. This also makes it clear that
the correct architecture is passed to gas based on -mcpu.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D58314
Files:
clang/lib/Driver/ToolChains/Arch/ARM.cpp
clang/lib/Driver/ToolChains/Arch/ARM.h
clang/lib/Driver/ToolChains/Gnu.cpp
clang/test/Driver/linux-as.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58314.187114.patch
Type: text/x-patch
Size: 10480 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190216/207a12f2/attachment.bin>
More information about the cfe-commits
mailing list