tmroeder added a comment.
In D58292#1399774 <https://reviews.llvm.org/D58292#1399774>, @shafik wrote:
> This looks reasonable, I will wait for @martong and/or @a_sidorin to review.
>
> FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run `check-lldb` especially on MacOS so you can to catch regressions before committing. After committing please make sure to monitor the GreenDragon build bots:
I don't currently have a macOS machine to try this on, but I'll see what I can do next week.
I ran check-lldb with and without my change, and I don't seem to have broken anything new. However, check-lldb fails in a few ways at head (at least in my configuration; maybe I did something wrong):
RESULT: FAILED (0 passes, 2 failures, 0 errors, 2 skipped, 0
expected failures, 0 unexpected successes)
********************
Testing Time: 59.67s
********************
Unexpected Passing Tests (2):
lldb-Suite :: functionalities/asan/TestMemoryHistory.py
lldb-Suite :: functionalities/asan/TestReportData.py
********************
Failing Tests (3):
lldb-Suite ::
functionalities/data-formatter/data-formatter-stl/libcxx/iterator/TestDataFormatterLibccIterator.py
lldb-Suite ::
functionalities/register/register_command/TestRegisters.py
lldb-Suite :: tools/lldb-server/TestGdbRemoteRegisterState.py
Expected Passes : 1480
Expected Failures : 1
Unsupported Tests : 33
Unexpected Passes : 2
Unexpected Failures: 3
FAILED: tools/lldb/lit/CMakeFiles/check-lldb-lit
cd /usr/local/google/home/tmroeder/src/llvm/llvm-build/release/tools/lldb/lit
&& /usr/bin/python2.7
/usr/local/google/home/tmroeder/src/llvm/llvm-build/release/./bin/llvm-lit
-sv
/usr/local/google/home/tmroeder/src/llvm/llvm-build/release/tools/lldb/lit
ninja: build stopped: subcommand failed.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58292/new/
https://reviews.llvm.org/D58292