[PATCH] D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier

[Lingda Li via Phabricator via cfe-commits]

lildmh added inline comments.


================
Comment at: include/clang/AST/OpenMPClause.h:3682-3685
+      OpenMPClauseKind K, SourceLocation StartLoc, SourceLocation LParenLoc,
+      SourceLocation EndLoc, OMPMappableExprListSizeTy Sizes,
+      NestedNameSpecifierLoc *MapperQualifierLocP = nullptr,
+      DeclarationNameInfo *MapperIdInfoP = nullptr)
----------------
ABataev wrote:
> I think it is worth to add `SourceLocation StartLoc`, `SourceLocation LParenLoc`, `SourceLocation EndLoc`, to `OMPMappableExprListSizeTy`. Of course, you need to rename the structure, something like `OMPMappableClauseData` is good enough. Or you can pack them into a different structure.
I put `StartLoc`, `LParenLoc`, `EndLoc` into another struct `OMPMappableExprListLocTy`. I didn't combine them with `OMPMappableExprListSizeTy`, because some fuctions only use one of them, and some other functions use both of them.

Also modify `to`, `from`, `is_device`, and `use_device` clauses to use the same interfaces.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58074/new/

https://reviews.llvm.org/D58074