[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 15 10:26:45 PST 2019


aaron.ballman added a subscriber: hansw.
aaron.ballman added a comment.

In D57948#1399403 <https://reviews.llvm.org/D57948#1399403>, @riccibruno wrote:

> (Following up on a discussion on IRC) I have looked at what would be needed to revert the set of patches which introduced this change, but this results in a >1k lines diff which do not apply cleanly. I think it might be safer to just merge this fix. Unless @aaron.ballman disagree, @hans  could you please merge this into the release branch ?


Thank you for looking into the 8.0 revert approach, @riccibruno! I'm okay with putting this patch on 8.0 instead -- you should file a new bug, mark it as blocking https://bugs.llvm.org/show_bug.cgi?id=40331, and make sure @hansw is CCed on the bug.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57948/new/

https://reviews.llvm.org/D57948





More information about the cfe-commits mailing list