[PATCH] D58269: [clang] Add build and install targets for clang libraries

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 14 18:50:25 PST 2019


smeenai added a comment.

A couple of things I noticed while writing this patch:

- clang guards its install target creation with `CMAKE_CONFIGURATION_TYPES`, whereas LLVM uses `LLVM_ENABLE_IDE`. Should clang be switched over to be consistent with LLVM?
- I realize we create the `install-clang-libraries-stripped` target (courtesy of `add_llvm_install_targets`), but don't actually add any dependencies to it, so it's a no-op. `llvm-libraries` has this problem too. I was thinking of just making `install-clang-libraries-stripped` synonymous with `install-clang-libraries`, because a lot of these libraries will be static, and stripping them makes them unusable since it removes their symbol tables. The target name will be a lie, but the behavior seems more useful. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58269/new/

https://reviews.llvm.org/D58269





More information about the cfe-commits mailing list