[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 14 14:43:07 PST 2019


erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, nickdesaulniers.
Herald added subscribers: jdoerfert, dexonsmith, jkorous.

...instead of just comparing rank. Also, fix a bad warning about `_Float16`, since its declared out of order in BuiltinTypes.def, meaning comparing rank using `BuiltinType::getKind()` is incorrect.

Came out of some discussion on D58145 <https://reviews.llvm.org/D58145>

Thanks!


https://reviews.llvm.org/D58254

Files:
  clang/include/clang/AST/ASTContext.h
  clang/lib/AST/ASTContext.cpp
  clang/lib/Sema/SemaChecking.cpp
  clang/test/Sema/conversion-target-dep.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58254.186919.patch
Type: text/x-patch
Size: 5370 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190214/bb9b8f19/attachment.bin>


More information about the cfe-commits mailing list