[PATCH] D58213: [FileManager] fillRealPathName even if we aren't opening the file

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 14 12:50:05 PST 2019


jkorous marked an inline comment as done.
jkorous added inline comments.


================
Comment at: unittests/Basic/FileManagerTest.cpp:349
 
+// rdar://problem/47536127
+TEST_F(FileManagerTest, getFileDontOpenRealPath) {
----------------
arphaman wrote:
> Please leave this comment out
Sure, no problem.

Just so I understand it - when it is appropriate to quote the radar? I see a lot of them in clang/test. Are these just from the "ancient" history?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58213/new/

https://reviews.llvm.org/D58213





More information about the cfe-commits mailing list