[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 14 10:46:58 PST 2019


vsk added subscribers: dblaikie, vsk.
vsk added a comment.

I think this could roughly double the memory utilization of the writer, which might be problematic because the number of records to write can be high. (@dblaikie did some work on reducing memory usage in this area, he might have hard data about this.)

As the write should only occur once, maybe the better tradeoff would be to sort?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57986/new/

https://reviews.llvm.org/D57986





More information about the cfe-commits mailing list