[PATCH] D58218: Variable auto-init of blocks capturing self after init bugfix

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 14 10:29:13 PST 2019


rjmccall added a comment.

In D58218#1398124 <https://reviews.llvm.org/D58218#1398124>, @jfb wrote:

> In D58218#1398096 <https://reviews.llvm.org/D58218#1398096>, @rjmccall wrote:
>
> > Well, you can always make a variable with a more directly-applicable name than `capturedByInit` and update it as appropriate, like `locIsByrefHeader`.
>
>
> Sounds good. I made it `const` too, to avoid inadvertent modification.


This is actually the reverse of the sense I would expect it to have based on the name.  If you want these semantics, maybe `locIsObject`?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58218/new/

https://reviews.llvm.org/D58218





More information about the cfe-commits mailing list