[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

Zinovy Nis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 14 01:43:16 PST 2019


zinovy.nis marked an inline comment as done.
zinovy.nis added inline comments.


================
Comment at: clang-tidy/tool/clang-tidy-diff.py:76
+    t = threading.Thread(target=tidy_caller, args=(task_queue, lock, timeout))
+    t.daemon = True
+    t.start()
----------------
JonasToth wrote:
> why daemonize? Who kills that thread in the end? I think it's not the best choice.
The script can be interrupted with keyabord or other signal, so it need not wait for any worker thread.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57662/new/

https://reviews.llvm.org/D57662





More information about the cfe-commits mailing list