[PATCH] D58060: Fix diagnostic for addr spaces in static_cast

Wed Feb 13 15:49:26 PST 2019

ebevhan added a comment.

In D58060#1396565 <https://reviews.llvm.org/D58060#1396565>, @Anastasia wrote:

> We had discussion related to this with John earlier. And I documented it in this bug: https://bugs.llvm.org/show_bug.cgi?id=39674

I think we observed something similar to this downstream in C, and I might have a patch(es) that fixes it.

> Yes, exactly. I am working on a patch now that separates the address space casting out into a function to be used in C-style cast only as a first step (because I would like to disallow accidental unsafe address space conversions in `reinterpret_cast`). Then we would just need to add parsing of a new cast operator and mapping into the new function.

Okay, sounds good!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58060/new/

https://reviews.llvm.org/D58060