[PATCH] D54978: Move the SMT API to LLVM

Dominic Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 15:36:54 PST 2019


ddcc added a comment.

In D54978#1397316 <https://reviews.llvm.org/D54978#1397316>, @mikhail.ramalho wrote:

> I just sent the first prototype of the solution. All the magic happens inside the `CHECK_CXX_SOURCE_RUNS` call.


I think hardcoding the version into the binary is too brittle. Instead, your program can just print out the current z3 version (much like the current execution of the z3 binary), and the remaining logic can remain in CMake, with the fallbacks as suggested above by @brzycki.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978





More information about the cfe-commits mailing list