[PATCH] D54978: Move the SMT API to LLVM

Dominic Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 12:34:36 PST 2019


ddcc added a comment.

In D54978#1396403 <https://reviews.llvm.org/D54978#1396403>, @brzycki wrote:

> That is almost exactly what I was thinking about this morning. I'd prefer the following since it's more robust for older versions:


The old `version.h` header isn't externally exposed, only the newer `z3_version.h` header starting with version 4.8.1. I built a copy of 4.7.1 from source, and I don't see it, so unfortunately I think the second check for `version.h` is superfluous. Instead, I think it'd be ok to still query the executable as the primary, then fallback to this header as the secondary?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54978/new/

https://reviews.llvm.org/D54978





More information about the cfe-commits mailing list