[PATCH] D58163: [CUDA][HIP] Use device side kernel and variable names when registering them

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: lib/CodeGen/CGCUDANV.cpp:412
+  for (auto &&I : EmittedKernels) {
+    llvm::Constant *KernelName = makeConstantString(I.DeviceSideName);
     llvm::Constant *NullPtr = llvm::ConstantPointerNull::get(VoidPtrTy);
----------------
tra wrote:
> Can we just call `getDeviceSideName()` here ? Mangling the name early and carrying it around does not seem to buy us anything.
getDeviceSideName() need to know Decl of the function. If we want to call it here, we have to carry Decl of the functions around.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58163/new/

https://reviews.llvm.org/D58163