[PATCH] D58178: isRawStringLiteral doesn't check all erroneous cases

Goran Mitrovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 08:14:18 PST 2019


gmit added a comment.

Sorry, this is my first LLVM commit, so I don't really know the procedure.

There is no test as it cannot be reproduced. The crash caused by this was spotted in one of our customer's crash dumps. The added condition should be obvious as it is tested in the assert just above.

Could you advise how to make a diff you'd like with TortoiseSVN? I don't seem to be able to add additional parameters. I have attached a new one with full path to the file.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58178/new/

https://reviews.llvm.org/D58178





More information about the cfe-commits mailing list