[PATCH] D58091: Customize warnings for missing built-in type

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 08:04:08 PST 2019


aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.

If I'm following along properly, it sounds like we want to disable this warning largely because it can appear in header files attempting to declare the functions in question -- but I wonder why those diagnostics are happening in the first place. It seems like the warning is still useful when it triggers outside of that situation, no?



================
Comment at: clang/lib/Sema/SemaDecl.cpp:1974
+
+    // Generally we emit a warning that the declaration requires the appropriate
+    // header.
----------------
Generally -> Generally,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58091/new/

https://reviews.llvm.org/D58091





More information about the cfe-commits mailing list